[Patch] Specular Highlight

Technical discussion for those interested in Supermodel development and Model 3 reverse engineering. Prospective contributors welcome.
Forum rules
Keep it classy!

  • No ROM requests or links.
  • Do not ask to be a play tester.
  • Do not ask about release dates.
  • No drama!

Re: [Patch] Specular Highlight

Postby YoYo09 » Thu Nov 23, 2017 8:42 am

Ian wrote:It might be a bug, make a save state and i'll try it out


here
https://drive.google.com/file/d/1Szl8c5 ... sp=sharing
YoYo09
 
Posts: 46
Joined: Mon Nov 28, 2016 7:43 pm

Re: [Patch] Specular Highlight

Postby Ian » Thu Nov 23, 2017 9:37 am

yeah you are right it's broken
I think i will just give up and do it completely in the fragment shader
Ian
 
Posts: 1406
Joined: Tue Feb 23, 2016 9:23 am

Re: [Patch] Specular Highlight

Postby Ian » Thu Nov 23, 2017 10:42 am

Right I fixed it ..
Can't believe it has taken so many attempts to get this right. The problem was caused by the fact the clamping to the range 0-1 must be done before fogIntensity is multiplied by the final value. Fog is supposed to be a simple per vertex attribute interpolated across the poly. But it turns out it's almost impossible to do it in the vertex shader because it's run before clipping happens. The model 3 must be calculating some of the attribs after clipping has been done. This can't be emulated directly in opengl, as the vertex shader always runs directly before clipping.
Attachments
fog final.jpg
fog final.jpg (178.21 KiB) Viewed 2231 times
Ian
 
Posts: 1406
Joined: Tue Feb 23, 2016 9:23 am

Re: [Patch] Specular Highlight

Postby YoYo09 » Fri Jan 05, 2018 7:54 pm

Ian
The specular new patch in November is not yet applied?
YoYo09
 
Posts: 46
Joined: Mon Nov 28, 2016 7:43 pm

Re: [Patch] Specular Highlight

Postby Ian » Sat Jan 06, 2018 5:00 pm

Not yet. Need some good comparisons to show the difference. The numbers Harry chose seem quite arbitrary. I would expect the coefficients to be something like power of two. Of course the ones Harry's chose could well be spot on, but without access to the specs it's very hard to reverse engineer.
Ian
 
Posts: 1406
Joined: Tue Feb 23, 2016 9:23 am

Re: [Patch] Specular Highlight

Postby YoYo09 » Tue Jan 09, 2018 6:21 pm

Ian
R696
Virtual On
bug found

R685 screenshot (Normal screen)
von2.JPG
r685
von2.JPG (177.48 KiB) Viewed 1922 times


R696 screenshot
von.JPG
R696 Bug
von.JPG (206.54 KiB) Viewed 1922 times
YoYo09
 
Posts: 46
Joined: Mon Nov 28, 2016 7:43 pm

Re: [Patch] Specular Highlight

Postby Ian » Wed Jan 10, 2018 2:23 pm

Yoyo
can you try with svn 699 ?
Ian
 
Posts: 1406
Joined: Tue Feb 23, 2016 9:23 am

Re: [Patch] Specular Highlight

Postby YoYo09 » Thu Jan 11, 2018 7:38 am

Ian wrote:Yoyo
can you try with svn 699 ?


R699 normal :D
thank you Ian
YoYo09
 
Posts: 46
Joined: Mon Nov 28, 2016 7:43 pm

Previous

Return to The Dark Room

Who is online

Users browsing this forum: YoYo09 and 3 guests