Ian wrote:It might be a bug, make a save state and i'll try it out
here
https://drive.google.com/file/d/1Szl8c5 ... sp=sharing
[Patch] Specular Highlight
Forum rules
Keep it classy!
Keep it classy!
- No ROM requests or links.
- Do not ask to be a play tester.
- Do not ask about release dates.
- No drama!
Re: [Patch] Specular Highlight
by YoYo09 » Thu Nov 23, 2017 8:42 am
here
https://drive.google.com/file/d/1Szl8c5 ... sp=sharing
- YoYo09
- Posts: 70
- Joined: Mon Nov 28, 2016 7:43 pm
Re: [Patch] Specular Highlight
by Ian » Thu Nov 23, 2017 9:37 am
yeah you are right it's broken
I think i will just give up and do it completely in the fragment shader
I think i will just give up and do it completely in the fragment shader
- Ian
- Posts: 1590
- Joined: Tue Feb 23, 2016 9:23 am
Re: [Patch] Specular Highlight
by Ian » Thu Nov 23, 2017 10:42 am
Right I fixed it ..
Can't believe it has taken so many attempts to get this right. The problem was caused by the fact the clamping to the range 0-1 must be done before fogIntensity is multiplied by the final value. Fog is supposed to be a simple per vertex attribute interpolated across the poly. But it turns out it's almost impossible to do it in the vertex shader because it's run before clipping happens. The model 3 must be calculating some of the attribs after clipping has been done. This can't be emulated directly in opengl, as the vertex shader always runs directly before clipping.
Can't believe it has taken so many attempts to get this right. The problem was caused by the fact the clamping to the range 0-1 must be done before fogIntensity is multiplied by the final value. Fog is supposed to be a simple per vertex attribute interpolated across the poly. But it turns out it's almost impossible to do it in the vertex shader because it's run before clipping happens. The model 3 must be calculating some of the attribs after clipping has been done. This can't be emulated directly in opengl, as the vertex shader always runs directly before clipping.
- Attachments
-
- fog final.jpg (178.21 KiB) Viewed 6455 times
- Ian
- Posts: 1590
- Joined: Tue Feb 23, 2016 9:23 am
Re: [Patch] Specular Highlight
by YoYo09 » Fri Jan 05, 2018 7:54 pm
Ian
The specular new patch in November is not yet applied?
The specular new patch in November is not yet applied?
- YoYo09
- Posts: 70
- Joined: Mon Nov 28, 2016 7:43 pm
Re: [Patch] Specular Highlight
by Ian » Sat Jan 06, 2018 5:00 pm
Not yet. Need some good comparisons to show the difference. The numbers Harry chose seem quite arbitrary. I would expect the coefficients to be something like power of two. Of course the ones Harry's chose could well be spot on, but without access to the specs it's very hard to reverse engineer.
- Ian
- Posts: 1590
- Joined: Tue Feb 23, 2016 9:23 am
Re: [Patch] Specular Highlight
by YoYo09 » Tue Jan 09, 2018 6:21 pm
Ian
R696
Virtual On
bug found
R685 screenshot (Normal screen)
R696 screenshot
R696
Virtual On
bug found
R685 screenshot (Normal screen)
- r685
- von2.JPG (177.48 KiB) Viewed 6146 times
R696 screenshot
- R696 Bug
- von.JPG (206.54 KiB) Viewed 6146 times
- YoYo09
- Posts: 70
- Joined: Mon Nov 28, 2016 7:43 pm
Re: [Patch] Specular Highlight
by YoYo09 » Thu Jan 11, 2018 7:38 am
Ian wrote:Yoyo
can you try with svn 699 ?
R699 normal
thank you Ian
- YoYo09
- Posts: 70
- Joined: Mon Nov 28, 2016 7:43 pm
Re: [Patch] Specular Highlight
by sonic32 » Wed Jan 23, 2019 4:49 am
Delete
Last edited by sonic32 on Thu Jan 24, 2019 2:42 am, edited 1 time in total.
-
sonic32 - Posts: 122
- Joined: Tue Dec 20, 2011 11:43 am
- Location: Slovakia
Re: [Patch] Specular Highlight
by Bart » Wed Jan 23, 2019 2:39 pm
This is off topic for the dev forum which is intended for development discussion, not feature requests.
-
Bart - Site Admin
- Posts: 2275
- Joined: Thu Sep 01, 2011 2:13 pm
- Location: New York City
Who is online
Users browsing this forum: No registered users and 2 guests