Fixing the mixing music in SR2

[Kacperas]

Regarding no sync, a few years ago, when sound/music weren't emulated, there was a talk about the way in which, it should be implemented. If anything hasn't changed since that time, then no sync is a design choice.

[Bart]

Spindizzi: regarding the VF3 fix:

Code: Select all

SCSPDSP_SetSample(&SCSPs[0].DSP,/*sample>>5*/(sample*LPANTABLE[(Enc|0xE0)/*&0xFFE0*/])>>(SHIFT+3)/*>>SHIFT*/,ISEL(slot),IMXL(slot));


What is the reasoning behind this? Did you consult with any documentation or the MAME source code to figure out that the masking the index to LPANTABLE is not necessary? I'm curious whether it might impact audio in other games.

[Conversus W. Vans]

I'm most excited if the SCSP sound ever gets updated, though it might be a long time. The Lost World's music is sounding grainy, but Harley-Davidson's sounds okay. At least the attract music works compared to the M1 music player.

[Jiterdomer]

We're still using Elsemi's audio code so that's why it had flaws to the audio emulation, so we will wait for someone to have better audio code to implement to Supermodel.

[Conversus W. Vans]

We're still using Elsemi's audio code so that's why it had flaws to the audio emulation, so we will wait for someone to have better audio code to implement to Supermodel.

Model 2 Emulator's isn't even perfect either, unfortunately. House of the Dead uses FM in some of its songs, and ElSemi never managed to perfect that. :\

[Spindizzi]

Hi,
I've no doc on this, I've certainly looked inside Mame source, to try to understand that part but Mame has a so different architecture compare to Supermodel. It's very hard for me to understand Mame
As I can remember, when The bug was reported, I've searched into soundboard code since I've a little learned by myself about soundboard for sr2
I've done multiple tests about SCSP part and the dsp in particular.When I disabled it, I immediately saw that it came from dsp part (I even enabled the old reverbe code in my tests)
So I was interested in each lines referring to the DSP
I build, test, change, spying variables, debuging frame by frame etc... And I saw every time the music collapse, the masking value change also (decreasing to 0, if I well remember)
Like I said in original post I can't explain why originaly it was needed to mask this value
Strangely, this doesn't have bad effects on other games and it can be easily reverted