[Patch] 2D-3D Layer Alignment (part 1)

Technical discussion for those interested in Supermodel development and Model 3 reverse engineering. Prospective contributors welcome.
Forum rules
Keep it classy!

  • No ROM requests or links.
  • Do not ask to be a play tester.
  • Do not ask about release dates.
  • No drama!

Re: [Patch] 2D-3D Layer Alignment (part 1)

Postby HarryTuttle » Tue Mar 21, 2017 3:28 am

Ian, I just checked the commit about layer alignment, I think since you shift only the 2D layer and seeing from some Abe's video that seems to be the intended behavior, I'd suggest to scissor only the right and bottom edges.

I've also discovered a bug when you choose native resolution: it leaves some garbage showing out (Daytona 2 BOTE intro). The following code snippet in <Main.cpp> cuts only the necessary and fixes the bug. Try it, then decide if it's worth integrating. :)

Code: Select all
// Scissor box (to clip visible area)
if (g_Config.wideScreen && VideoInfo->current_w > int(*xResPtr)) {
   glScissor(0, *yOffsetPtr + correction, *totalXResPtr, *totalYResPtr - correction);
}
else {
   glScissor(*xOffsetPtr, *yOffsetPtr + correction, *xResPtr - correction, *yResPtr - correction);
}
User avatar
HarryTuttle
 
Posts: 646
Joined: Thu Mar 09, 2017 8:57 am

Re: [Patch] 2D-3D Layer Alignment (part 1)

Postby Ian » Tue Mar 21, 2017 3:40 am

I'll check it out when I am not at work lol
Might just be an rounding issue or something :)
Ian
 
Posts: 2044
Joined: Tue Feb 23, 2016 9:23 am

Re: [Patch] 2D-3D Layer Alignment (part 1)

Postby Ian » Tue Mar 21, 2017 2:30 pm

can you take a screenshot of the bug?
Ian
 
Posts: 2044
Joined: Tue Feb 23, 2016 9:23 am

Re: [Patch] 2D-3D Layer Alignment (part 1)

Postby HarryTuttle » Wed Mar 22, 2017 11:19 am

Very sorry to respond late, I've been a lot busy lately.

Anyway here's the screenshot. Basically every time the 2D layer clears, something remains from the underneath 3D. It doesn't scissor correctly, which is the part of the code that I've modified.
Attachments
bug_du2bote_1.jpeg
bug_du2bote_1.jpeg (46.21 KiB) Viewed 5112 times
User avatar
HarryTuttle
 
Posts: 646
Joined: Thu Mar 09, 2017 8:57 am

Re: [Patch] 2D-3D Layer Alignment (part 1)

Postby Ian » Wed Mar 22, 2017 11:48 am

thanks :)
Ian
 
Posts: 2044
Joined: Tue Feb 23, 2016 9:23 am

Re: [Patch] 2D-3D Layer Alignment (part 1)

Postby Ian » Wed Mar 22, 2017 12:10 pm

On a side note .. battle on the edge is probably one of the most broken model 3 games. The timing is completely fubar and it's quite often trying to render in the middle of writing the graphics data
Ian
 
Posts: 2044
Joined: Tue Feb 23, 2016 9:23 am

Previous

Return to The Dark Room

Who is online

Users browsing this forum: No registered users and 1 guest

cron