Page 11 of 11

Re: [Patch] Specular Highlight

PostPosted: Thu Nov 23, 2017 8:42 am
by YoYo09
Ian wrote:It might be a bug, make a save state and i'll try it out


here
https://drive.google.com/file/d/1Szl8c5 ... sp=sharing

Re: [Patch] Specular Highlight

PostPosted: Thu Nov 23, 2017 9:37 am
by Ian
yeah you are right it's broken
I think i will just give up and do it completely in the fragment shader

Re: [Patch] Specular Highlight

PostPosted: Thu Nov 23, 2017 10:42 am
by Ian
Right I fixed it ..
Can't believe it has taken so many attempts to get this right. The problem was caused by the fact the clamping to the range 0-1 must be done before fogIntensity is multiplied by the final value. Fog is supposed to be a simple per vertex attribute interpolated across the poly. But it turns out it's almost impossible to do it in the vertex shader because it's run before clipping happens. The model 3 must be calculating some of the attribs after clipping has been done. This can't be emulated directly in opengl, as the vertex shader always runs directly before clipping.

Re: [Patch] Specular Highlight

PostPosted: Fri Jan 05, 2018 7:54 pm
by YoYo09
Ian
The specular new patch in November is not yet applied?

Re: [Patch] Specular Highlight

PostPosted: Sat Jan 06, 2018 5:00 pm
by Ian
Not yet. Need some good comparisons to show the difference. The numbers Harry chose seem quite arbitrary. I would expect the coefficients to be something like power of two. Of course the ones Harry's chose could well be spot on, but without access to the specs it's very hard to reverse engineer.

Re: [Patch] Specular Highlight

PostPosted: Tue Jan 09, 2018 6:21 pm
by YoYo09
Ian
R696
Virtual On
bug found

R685 screenshot (Normal screen)
von2.JPG
r685
von2.JPG (177.48 KiB) Viewed 9638 times


R696 screenshot
von.JPG
R696 Bug
von.JPG (206.54 KiB) Viewed 9638 times

Re: [Patch] Specular Highlight

PostPosted: Wed Jan 10, 2018 2:23 pm
by Ian
Yoyo
can you try with svn 699 ?

Re: [Patch] Specular Highlight

PostPosted: Thu Jan 11, 2018 7:38 am
by YoYo09
Ian wrote:Yoyo
can you try with svn 699 ?


R699 normal :D
thank you Ian

Re: [Patch] Specular Highlight

PostPosted: Wed Jan 23, 2019 4:49 am
by sonic32
Delete

Re: [Patch] Specular Highlight

PostPosted: Wed Jan 23, 2019 2:39 pm
by Bart
This is off topic for the dev forum which is intended for development discussion, not feature requests.