[Patch] Fixed Shading

[terminento]

How so?

[HarryTuttle]

This is my latest take on fixed shading. I think step 2.x values are near perfect although I'm not still 100% sure since they depends on lighting and normal values that, on their turn, could depend on that mysterious transformation matrix scale value that affects how much sun a single model receives.

Pseudo-code:

Code: Select all

// Step 1.0 doesn't use fixed-shading at all
if (!ph.LightEnabled()) {
   if (m_step == 0x15) {
      shade = 1.5f; // Over-illuminates Lost World gun calibration screen, but fixes Scud Race
   }
}
else {
   shade = 1.0f;
}

if (ph.FixedShading() && !ph.SmoothShading()) {
   if (m_step > 0x15) { // Step 2.x
      if (ph.LightEnabled()) {
         if (ph.TranslatorMap()) {
            shade = 1.0f + (float)(INT8)(ix & 0xFF) / 255.0f;
         }
         else {
            if (vpAmbientLight > 0.5) {
               shade = 0.5f + (float)(INT8)(ix & 0xFF) / 255.0f;
            }
            else if (vpAmbientLight == 0) {
               shade = (float)(UINT8)(ix & 0xFF) / 255.0f;
            }
            else {
               shade = vpAmbientLight + (float)(UINT8)(ix & 0xFF) / 255.0f;
            }
         }
      }
   }
   else if (m_step == 0x15) { // Step 1.5
      // Model 3 Step 1.5 doesn't seem to use TranslatorMap.
      if (ph.LightEnabled()) {
         float factor = (float)((UINT8)(ix & 0x7F)) / 127.0f;
         if (vpAmbientLight > 0.0f)
            shade = 0.5 + factor;
         else
            shade = factor;
      }
      else {
         shade = 2.0f;
      }
   }
}

p.v[j].color[0] = shade;
p.v[j].color[1] = shade;
p.v[j].color[2] = shade;
p.v[j].color[3] = 1.0f;


[HarryTuttle]

Arcade looks like this ( really poor quality ) anyone got any better caps?

These are all the arcade video I've found:
https://www.youtube.com/watch?v=CqHWjjydFjE
https://www.youtube.com/watch?v=ffaZ9NDI_zU
https://www.youtube.com/watch?v=kFtYayAHmlc
https://www.youtube.com/watch?v=y44wZ13kdqk
https://www.youtube.com/watch?v=Kx0BzdwKDzA
https://www.youtube.com/watch?v=E0yo1lLFap0
https://www.youtube.com/watch?v=DuIMCfRklF8
https://www.youtube.com/watch?v=ljiaMzKTkZk

[Ian]

That's good work

[Ian]

This is the best quality footage I found
https://www.youtube.com/watch?v=UBhdNCuXq94
But doesn't have the canyon scene

[HarryTuttle]

Thanks Ian, I missed that footage! I'm going to dl that and add to my huge collection of model3 videos...

[Ian]

I've got a few more of these if you are interested
https://www.youtube.com/watch?v=b05KB00efys
Not technically model3, but original real3d videos

[HarryTuttle]

Already got that... I remember to have downloaded years ago all the videos I could from the Real3D site before it closed.

If you're interested...

[Ian]

Here's one from that video capture ..


I guess that the min value is clamped somehow. The upper brightness doesn't seem to have increased, although it's hard to tell off a recording off a CRT ..

[HarryTuttle]

I guess that the min value is clamped somehow. The upper brightness doesn't seem to have increased

Does it behave like this with the current build or with my patch? Because I've just checked mine and it's fine.

mta2.jpeg (211.56 KiB) Viewed 7976 times