Page 93 of 99

Re: Supermodel Latest Builds for Download (currently SVN 883

PostPosted: Tue Jun 14, 2022 1:01 pm
by Ian

Re: Supermodel Latest Builds for Download (currently SVN 883

PostPosted: Wed Jun 15, 2022 3:31 pm
by rokfpoewrkcpoqwkcp
Questions about the quad sound in r883. I'm unsure of the correct usage of -channels=<c> and the expected behaviour.

I'm using stereo line out into a 2 speaker system, so i pass -channels=2, is this needed or do I leave as default?
I'm confused as -channels=2 makes the overall sound a little louder than the default -channels=4, as I would expect, although I would of thought that the rear sounds would disappear whilst using -channels=4 (on a 2 speaker system); but they don't seem to?

Also, while I've been trying to work this out, I've been using the F9 to F12 keys to adjust sound and music values while playing Daytona2pe. I've noticed the pit crew boss and rear collision sounds don't obey the global sound value. They stay the same level even when sound and music is muted. I guess this isn't intended?
Are some of the channels bypassing the overall sound level logic?

BTW
Great to see Supermodel still getting meaningful updates after all these years. The hours of work that goes into the many lines of code for each and every change is very much appreciated. :D

Re: Supermodel Latest Builds for Download (currently SVN 886

PostPosted: Thu Jun 16, 2022 1:29 am
by Jiterdomer
Small update just for fighting game fans, here's r886!

Re: Supermodel Latest Builds for Download (currently SVN 883

PostPosted: Thu Jun 16, 2022 3:59 am
by Ian
CCCP1982 wrote:
CCCP1982 wrote:r883
The game has porridge in the polygons where it is the core of the Death Star.

Showed an error in the video
https://disk.yandex.ru/i/CBMlbebl49A87w


yeah i know about this
It's jtag related which we still don't emulate properly yet

Re: Supermodel Latest Builds for Download (currently SVN 886

PostPosted: Thu Jun 16, 2022 12:02 pm
by njz3
If you use a computer with stereo sound output only, the default behavior should be 4 channels mixed down to stereo, as it was before the patch.
The -channels option will allow people to select a lower number of channels, for example getting mono or stereo instead of quadriphony if your computer allows.
There may be some bugs that I have to fix. I will check what you reported about sound volume not being taken into account.

Re: Supermodel Latest Builds for Download (currently SVN 886

PostPosted: Thu Jun 16, 2022 3:18 pm
by rokfpoewrkcpoqwkcp
@njz3

Thanks for the explanation. Great to see new Devs joining the Supermodel team. Appreciate the work.

Re: Supermodel Latest Builds for Download (currently SVN 886

PostPosted: Fri Jun 17, 2022 10:52 am
by njz3
I know why the sound is doubled when you set 2 channels instead of 4.
With 4 channels, the mixing down to stereo is performed by the SDL library, which mix the values.
When you enforce 2 channels, the mixing is done by supermodel, simply adding the samples and not correcting the amplitude.
I can fix that (well, I fixed it already).

Regarding the sound and music volume : my first understanding of the current code is that music volume is only for DSB, and sound volume apply to SCSP (sound effects).
Some games use SCSP for music also, case of Lemans that has no DSB, and also for some ingame music that are not played by the DSB.
I will look into the sound volume bug for the pit crew and rear sounds (rear channels I guess).
Once fix with the first above corrections, I will submit to Ian for inclusion in supermodel.

Re: Supermodel Latest Builds for Download (currently SVN 886

PostPosted: Fri Jun 17, 2022 2:17 pm
by njz3
@rokfpoewrkcpoqwkcp
Interestingly, I see in the current code and with older versions of supermodel (<r883) that games with no DSB board (so no "music" as supermodel reports like lemans) does not change sound volume as you would expect. Can you also confirm this ?
It seems like sound volume is applied by the DSB code only (weird...) that is only mixed with front channels. So that explains why sound volume does not apply to rear channels.
I guess this is the source of the bug, it is not so simple to fix as I need to revise how this "sound volume" parameter is used internally.

Re: Supermodel Latest Builds for Download (currently SVN 886

PostPosted: Fri Jun 17, 2022 3:01 pm
by rokfpoewrkcpoqwkcp
Ah yes, you are correct. LeMans doesn't respect the sound volume, even with the old -legacy-scsp setting. Now you mention it, I think that might of been noted in this forum before somewhere.
The good news is no one can blame you for breaking anything. You've actually kept Supermodel functionality perfectly intact. :D
I wouldn't take it upon yourself to fix something that was always there, especially if it's hard to untangle. As long as people know how to use the sound options and the limitations of them, they will be fine.

Re: Supermodel Latest Builds for Download (currently SVN 886

PostPosted: Fri Jun 17, 2022 3:28 pm
by njz3
Bugs should be fixed. Can you try an experimental build here:
https://github.com/njz3/model3emu/relea ... f3-x64.zip
I will ask Ian to review the code for inclusion.