compile with debugger help

[solitarius576]

mingw32-make ENABLE_DEBUGGER=1 -f Makefiles/Makefile.Win32
I use the above command, is it correct?
I get the following error

Code: Select all

Generating dependencies: Src/OSD/SDL/Main.cpp -> obj64/Main.d
Compiling              : Src/OSD/SDL/Main.cpp -> obj64/Main.o
Src/OSD/SDL/Main.cpp:877:106: error: 'IScripting' has not been declared
  877 | int Supermodel(const Game &game, ROMSet *rom_set, IEmulator *Model3, CInputs *Inputs, COutputs *Outputs, IScripting* scripting, std::shared_ptr<Debugger::CDebugger> Debugger)
      |                                                                                                          ^~~~~~~~~~
Src/OSD/SDL/Main.cpp: In function 'int SDL_main(int, char**)':
Src/OSD/SDL/Main.cpp:1997:66: error: cannot convert 'std::shared_ptr<Debugger::CSupermodelDebugger>' to 'int*'
 1997 |   exitCode = Supermodel(game, &rom_set, Model3, Inputs, Outputs, Debugger);
      |                                                                  ^~~~~~~~
      |                                                                  |
      |                                                                  std::shared_ptr<Debugger::CSupermodelDebugger>
Src/OSD/SDL/Main.cpp:877:118: note:   initializing argument 6 of 'int Supermodel(const Game&, ROMSet*, IEmulator*, CInputs*, COutputs*, int*, std::shared_ptr<Debugger::CDebugger>)'
  877 | int Supermodel(const Game &game, ROMSet *rom_set, IEmulator *Model3, CInputs *Inputs, COutputs *Outputs, IScripting* scripting, std::shared_ptr<Debugger::CDebugger> Debugger)
      |                                                                                                          ~~~~~~~~~~~~^~~~~~~~~
mingw32-make: *** [Makefiles/Rules.inc:280: obj64/Main.o] Error 1



mingw32-make -f Makefiles/Makefile.Win32
this builds without errors, but off course no debugger

[rokfpoewrkcpoqwkcp]

Ian fixed this in the Sourceforge repo but it missed the move to GitHub.

Here's the commit...
https://sourceforge.net/p/model3emu/code/888/

He just removed the scripting parameter. I think it' s a remnant of one of njz3's branches.

[Bart]

Submit a PR on GitHub. Now's your chance to go down in history as part of Supermodel's commit log

[solitarius576]

thx
it compiles now, after making the modification

[rokfpoewrkcpoqwkcp]

Submit a PR on GitHub. Now's your chance to go down in history as part of Supermodel's commit log

Will do.

Funny thing is, I was going to submit my commit "Align ROM names with MAME" immediately, just so I would be first. Then I came to my senses and waited for some body else to go first, as a change to just the Games.xml would trigger an unnecessary rebuild. I think the push got it's own build in the end anyway, but never mind