star wars credits bug

[Ian]

Thought I'd just write it here .. to keep track of this

Stat Wars Trilogy (Revision A)
save
https://mega.nz/#!fJ8WXYpR!JlMadTp27Nzt ... BcHAjukP6g

The problem is with the 2D layer.

[HarryTuttle]

Could it be related to texture black stripes we see also before each mission?

[Ian]

Honestly I've never really played star wars
but I guess it's probably the same bug
Probably something timing related

[Bart]

Need to look into this when I get some time (I'm scrambling to get an entry in for next week's #hololens_challenge) but I wonder if it has something to do with the game accessing VRAM using non-32-bit accesses? Total long shot here and I forgot what Supermodel does exactly but I do seem to recall that most games will touch VRAM in 32-bit words and I don't think I ever wrote handlers for, say, 16-bit or 8-bit accesses. Maybe they're possible after all.

[Ian]

All the text in the background is drawn as polys.
So what's onscreen in the 2d layers is about as simple as possible
So hopefully wont be too hard to debug

[Ian]

Bart
It's missing the read16 methods for the tilegen. That's what star wars is calling.
If you implement those I guess it might even work

[Spindizzi]

Seems you're right
rapid test : just copy from Read32 and adapt for Read16

Code: Select all

  case 0xF1:
     //printf("Tilegen READ 16\n");
     data = TileGen.ReadRAM((addr & 0x1FFFFF));
     return FLIPENDIAN16(data);


Do it only for ram access, don't know if registers are accessed in the read16 method. Only Bart can correct this rigorously
This corrects the vertical black bars but not the speed of the scrolling, cool
++

[Bart]

I've just integrated a proper fix into my branch but realized that I can't push it due to the other changes I have in there. Tuesday evening I will make a fix to the public branch. I've added support for reading/writing 8- and 16-bit values.

Ian: please don't commit any tilegen-related fixes. I'll take care of this.

[Ian]

Sure
Wonder if that fixes other games. Spike out has some really crazy 2d bugs if you leave attract mode long enough

[Bart]

I've committed the fix. Didn't test thoroughly but confirmed it works on the Yavin mission intro screen...